Add aes-encryption for backups #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
requested changes
Oct 7, 2024
Gerrit91
reviewed
Oct 7, 2024
majst01
requested changes
Oct 8, 2024
Gerrit91
reviewed
Oct 8, 2024
majst01
reviewed
Oct 9, 2024
majst01
reviewed
Oct 14, 2024
Gerrit91
reviewed
Oct 14, 2024
Gerrit91
reviewed
Oct 23, 2024
| return fmt.Errorf("unable to decrypt backup: %w", err) | ||
| } | ||
| } | ||
| i.log.Info("restoring unencrypted backup with configured encryption - skipping decryption...") |
There was a problem hiding this comment.
This log line seems to be wrong because it's always shown. No matter if it was encrypted or not.
Gerrit91
reviewed
Oct 23, 2024
Comment on lines
235
to
236
| e.log.Info("read %d bytes: %s", strconv.Itoa(n), err) | ||
| break |
There was a problem hiding this comment.
Maybe it would be more secure to do this?
Suggested change
| e.log.Info("read %d bytes: %s", strconv.Itoa(n), err) | |
| break | |
| return fmt.Errorf("error reading from file (%d bytes read): %w", strconv.Itoa(n), err) |
Gerrit91
reviewed
Oct 23, 2024
Comment on lines
180
to
181
| e.log.Info("read %d bytes: %s", strconv.Itoa(n), err) | ||
| break |
Gerrit91
reviewed
Oct 23, 2024
Comment on lines
169
to
179
| needsBackup, err := i.db.Check(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("unable retrieve backup versions: %w", err) | ||
| return fmt.Errorf("unable to check data of database: %w", err) | ||
| } | ||
|
|
||
| latestBackup := versions.Latest() | ||
| if latestBackup == nil { | ||
| i.log.Info("there are no backups available, it's a fresh database. allow database to start") | ||
| if !needsBackup { | ||
| i.log.Info("database does not need to be restored") | ||
| return nil | ||
| } | ||
|
|
||
| i.log.Info("database potentially needs to be restored, looking for backup") |
There was a problem hiding this comment.
In order to increase availability of the DB we should do this check before validating the backups.
Gerrit91
approved these changes
Oct 23, 2024
majst01
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #31.
References:
Additional Description
Because database can contain sensible data it should be encrypted. Adds aes-encryption to the default workflow.
Release Notes
Breaking Change
NONE
Required Actions
NONE